[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' b
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property |
Date: |
Mon, 14 Dec 2015 19:35:14 +0200 |
On Mon, Dec 14, 2015 at 12:28:50PM -0500, Paolo Bonzini wrote:
> > Well qapi/qmp docs say things like:
> >
> > Any name (command, event, type, field, or enum value) beginning with
> > "x-" is marked experimental, and may be withdrawn or changed
> > incompatibly in a future release.
> >
> > It's thus reasonable to use this for internal properties,
> > that we don't want users to play with.
>
> What distinguishes an internal from an external property? Everything
> except links to backends would be "internal".
How do you mean? We have a ton of properties e.g.
to control which offloads are allowed for virtio net.
Internal are properties which are not there for users,
performing some technical function instead.
> We've used a much more restrictive definition so far than that---basically
> known-broken or debugging-only---and I think it's more appropriate.
>
> > BTW, we probably should teach -help to hide these options by default.
>
> Please, no obscuring of functionality. Debugging-only functionality
> definitely belongs in -help.
>
> Paolo
Sure. This option is not for debugging though.
It's set internally by machine types to avoid breaking
migration. I don't see any reason for users to set it.
--
MST
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, (continued)
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Michael S. Tsirkin, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Paolo Bonzini, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Shmulik Ladkani, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Michael S. Tsirkin, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Shmulik Ladkani, 2015/12/15
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Marcel Apfelbaum, 2015/12/14
[Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Shmulik Ladkani, 2015/12/13
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Paolo Bonzini, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Michael S. Tsirkin, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Paolo Bonzini, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Paolo Bonzini, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Michael S. Tsirkin, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Shmulik Ladkani, 2015/12/15
Re: [Qemu-devel] [PATCH v2 0/6] pvscsi: Fine-tune device capabilities, Dmitry Fleytman, 2015/12/13