[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for inc
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames |
|
Date: |
Tue, 15 Dec 2015 07:47:29 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 14/12/15 23:06, Samuel Thibault wrote:
> Thomas Huth, on Mon 14 Dec 2015 18:50:49 +0100, wrote:
>>> + default:
>>> + /* Do not assert while we don't manage IP6VERSION */
>>> + /* assert(0); */
>>
>> Not sure if we ever want to have an assert() here - since I assume this
>> could be triggered by the guest?
>
> No, this is if_encap, so packets that slirp builds for the guest, so it
> shouldn't ever happen. The input side is in slirp_input(), which just
> ignores frames with unknown protocol.
OK, in that case the assert() is of course the right choice. Thanks for
the explanation!
Thomas
- [Qemu-devel] [PATCHv6 0/9] slirp: Adding IPv6 support to Qemu -net user mode, Samuel Thibault, 2015/12/14
- [Qemu-devel] [PATCH 2/9] slirp: Generalizing and neutralizing ARP code, Samuel Thibault, 2015/12/14
- [Qemu-devel] [PATCH 4/9] slirp: Make Socket structure IPv6 compatible, Samuel Thibault, 2015/12/14
- [Qemu-devel] [PATCH 5/9] slirp: Factorizing address translation, Samuel Thibault, 2015/12/14
- [Qemu-devel] [PATCH 6/9] slirp: Factorizing and cleaning solookup(), Samuel Thibault, 2015/12/14
- [Qemu-devel] [PATCH 9/9] slirp: Adding family argument to tcp_fconnect(), Samuel Thibault, 2015/12/14
- [Qemu-devel] [PATCH 7/9] slirp: Add sockaddr_equal, make solookup family-agnostic, Samuel Thibault, 2015/12/14