Re: [Qemu-devel] [RFC v6 06/14] configure: Use slow-path for atomic only when the softmmu is enabled

[alvise rigo]

Hi,

On Mon, Dec 14, 2015 at 11:14 AM, Laurent Vivier <address@hidden> wrote:
>
>
> On 14/12/2015 09:41, Alvise Rigo wrote:
>> Use the new slow path for atomic instruction translation when the
>> softmmu is enabled.
>>
>> Suggested-by: Jani Kokkonen <address@hidden>
>> Suggested-by: Claudio Fontana <address@hidden>
>> Signed-off-by: Alvise Rigo <address@hidden>
>> ---
>>  configure | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/configure b/configure
>> index b9552fd..cc3891a 100755
>> --- a/configure
>> +++ b/configure
>> @@ -4794,6 +4794,7 @@ echo "Install blobs     $blobs"
>>  echo "KVM support       $kvm"
>>  echo "RDMA support      $rdma"
>>  echo "TCG interpreter   $tcg_interpreter"
>> +echo "use ld/st excl    $softmmu"
>>  echo "fdt support       $fdt"
>>  echo "preadv support    $preadv"
>>  echo "fdatasync         $fdatasync"
>> @@ -5186,6 +5187,9 @@ fi
>>  if test "$tcg_interpreter" = "yes" ; then
>>    echo "CONFIG_TCG_INTERPRETER=y" >> $config_host_mak
>>  fi
>> +if test "$softmmu" = "yes" ; then
>> +  echo "CONFIG_TCG_USE_LDST_EXCL=y" >> $config_host_mak
>> +fi
>
> why is this "$softmmu" and not "$target_softmmu" ?

I see now that is $target_softmmu setting CONFIG_SOFTMMU=y.
So for my understanding, which are the cases where $softmmu is set
while $target_softmmu is not?

Thank you,
alvise

>
>>  if test "$fdatasync" = "yes" ; then
>>    echo "CONFIG_FDATASYNC=y" >> $config_host_mak
>>  fi
>>