qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 12/14] pc: Move PcGuestInfo.fw_cfg to PCMachi


From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PATCH v2 12/14] pc: Move PcGuestInfo.fw_cfg to PCMachineState
Date: Tue, 15 Dec 2015 16:28:46 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 12/11/2015 08:42 PM, Eduardo Habkost wrote:
Signed-off-by: Eduardo Habkost <address@hidden>
---
  hw/i386/acpi-build.c |  7 +++----
  hw/i386/pc.c         | 10 ++++------
  include/hw/i386/pc.h |  2 +-
  3 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 9598eac..43d8166 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1902,11 +1902,10 @@ void acpi_setup(void)
  {
      PCMachineState *pcms = PC_MACHINE(qdev_get_machine());
      PCMachineClass *pcmc = PC_MACHINE_GET_CLASS(pcms);
-    PcGuestInfo *guest_info = &pcms->acpi_guest_info;
      AcpiBuildTables tables;
      AcpiBuildState *build_state;

-    if (!guest_info->fw_cfg) {
+    if (!pcms->fw_cfg) {
          ACPI_BUILD_DPRINTF("No fw cfg. Bailing out.\n");
          return;
      }
@@ -1937,7 +1936,7 @@ void acpi_setup(void)
      build_state->linker_mr =
          acpi_add_rom_blob(build_state, tables.linker, "etc/table-loader", 0);

-    fw_cfg_add_file(guest_info->fw_cfg, ACPI_BUILD_TPMLOG_FILE,
+    fw_cfg_add_file(pcms->fw_cfg, ACPI_BUILD_TPMLOG_FILE,
                      tables.tcpalog->data, acpi_data_len(tables.tcpalog));

      if (!pcmc->rsdp_in_ram) {
@@ -1949,7 +1948,7 @@ void acpi_setup(void)
          uint32_t rsdp_size = acpi_data_len(tables.rsdp);

          build_state->rsdp = g_memdup(tables.rsdp->data, rsdp_size);
-        fw_cfg_add_file_callback(guest_info->fw_cfg, ACPI_BUILD_RSDP_FILE,
+        fw_cfg_add_file_callback(pcms->fw_cfg, ACPI_BUILD_RSDP_FILE,
                                   acpi_build_update, build_state,
                                   build_state->rsdp, rsdp_size);
          build_state->rsdp_mr = NULL;
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 02d0e19..6d8ea76 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1171,10 +1171,10 @@ void pc_machine_done(Notifier *notifier, void *data)
                  extra_hosts++;
              }
          }
-        if (extra_hosts && pcms->acpi_guest_info.fw_cfg) {
+        if (extra_hosts && pcms->fw_cfg) {
              uint64_t *val = g_malloc(sizeof(*val));
              *val = cpu_to_le64(extra_hosts);
-            fw_cfg_add_file(pcms->acpi_guest_info.fw_cfg,
+            fw_cfg_add_file(pcms->fw_cfg,
                      "etc/extra-pci-roots", val, sizeof(*val));
          }
      }
@@ -1257,7 +1257,6 @@ void xen_load_linux(PCMachineState *pcms)
  {
      int i;
      FWCfgState *fw_cfg;
-    PcGuestInfo *guest_info = &pcms->acpi_guest_info;

      assert(MACHINE(pcms)->kernel_filename != NULL);

@@ -1270,7 +1269,7 @@ void xen_load_linux(PCMachineState *pcms)
                 !strcmp(option_rom[i].name, "multiboot.bin"));
          rom_add_option(option_rom[i].name, option_rom[i].bootindex);
      }
-    guest_info->fw_cfg = fw_cfg;
+    pcms->fw_cfg = fw_cfg;
  }

  void pc_memory_init(PCMachineState *pcms,
@@ -1278,7 +1277,6 @@ void pc_memory_init(PCMachineState *pcms,
                      MemoryRegion *rom_memory,
                      MemoryRegion **ram_memory)
  {
-    PcGuestInfo *guest_info = &pcms->acpi_guest_info;
      int linux_boot, i;
      MemoryRegion *ram, *option_rom_mr;
      MemoryRegion *ram_below_4g, *ram_above_4g;
@@ -1399,7 +1397,7 @@ void pc_memory_init(PCMachineState *pcms,
      for (i = 0; i < nb_option_roms; i++) {
          rom_add_option(option_rom[i].name, option_rom[i].bootindex);
      }
-    guest_info->fw_cfg = fw_cfg;
+    pcms->fw_cfg = fw_cfg;
  }

  qemu_irq pc_allocate_cpu_irq(void)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 20a425c..a80adc6 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -27,7 +27,6 @@ struct PcGuestInfo {
      uint64_t numa_nodes;
      uint64_t *node_mem;
      uint64_t *node_cpu;
-    FWCfgState *fw_cfg;
  };

  /**
@@ -49,6 +48,7 @@ struct PCMachineState {
      HotplugHandler *acpi_dev;
      ISADevice *rtc;
      PCIBus *bus;
+    FWCfgState *fw_cfg;

      /* Configuration options: */
      uint64_t max_ram_below_4g;


Looks OK to me.

Reviewed-by: Marcel Apfelbaum <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]