[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v6 06/14] configure: Use slow-path for atomic only
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [RFC v6 06/14] configure: Use slow-path for atomic only when the softmmu is enabled |
Date: |
Tue, 15 Dec 2015 16:18:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 15/12/2015 15:31, Paolo Bonzini wrote:
>
>
> On 15/12/2015 15:23, alvise rigo wrote:
>> Hi,
>>
>> On Mon, Dec 14, 2015 at 11:14 AM, Laurent Vivier <address@hidden> wrote:
>>>
>>>
>>> On 14/12/2015 09:41, Alvise Rigo wrote:
>>>> Use the new slow path for atomic instruction translation when the
>>>> softmmu is enabled.
>>>>
>>>> Suggested-by: Jani Kokkonen <address@hidden>
>>>> Suggested-by: Claudio Fontana <address@hidden>
>>>> Signed-off-by: Alvise Rigo <address@hidden>
>>>> ---
>>>> configure | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/configure b/configure
>>>> index b9552fd..cc3891a 100755
>>>> --- a/configure
>>>> +++ b/configure
>>>> @@ -4794,6 +4794,7 @@ echo "Install blobs $blobs"
>>>> echo "KVM support $kvm"
>>>> echo "RDMA support $rdma"
>>>> echo "TCG interpreter $tcg_interpreter"
>>>> +echo "use ld/st excl $softmmu"
>>>> echo "fdt support $fdt"
>>>> echo "preadv support $preadv"
>>>> echo "fdatasync $fdatasync"
>>>> @@ -5186,6 +5187,9 @@ fi
>>>> if test "$tcg_interpreter" = "yes" ; then
>>>> echo "CONFIG_TCG_INTERPRETER=y" >> $config_host_mak
>>>> fi
>>>> +if test "$softmmu" = "yes" ; then
>>>> + echo "CONFIG_TCG_USE_LDST_EXCL=y" >> $config_host_mak
>>>> +fi
>>>
>>> why is this "$softmmu" and not "$target_softmmu" ?
>>
>> I see now that is $target_softmmu setting CONFIG_SOFTMMU=y.
>> So for my understanding, which are the cases where $softmmu is set
>> while $target_softmmu is not?
>
> When compiling foo-linux-user.
In fact, after having asked the question, I've found that it is right to
use softmmu which is a host parameter (while target_softmmu is guest
parameter) and softmmu is set to true if there is at least one *-softmmu
target.
Laurent
[Qemu-devel] [RFC v6 04/14] softmmu: Add helpers for a new slowpath, Alvise Rigo, 2015/12/14
[Qemu-devel] [RFC v6 05/14] tcg: Create new runtime helpers for excl accesses, Alvise Rigo, 2015/12/14
[Qemu-devel] [RFC v6 01/14] exec.c: Add new exclusive bitmap to ram_list, Alvise Rigo, 2015/12/14
[Qemu-devel] [RFC v6 08/14] target-arm: Add atomic_clear helper for CLREX insn, Alvise Rigo, 2015/12/14
[Qemu-devel] [RFC v6 10/14] softmmu: Simplify helper_*_st_name, wrap unaligned code, Alvise Rigo, 2015/12/14
[Qemu-devel] [RFC v6 07/14] target-arm: translate: Use ld/st excl for atomic insns, Alvise Rigo, 2015/12/14
[Qemu-devel] [RFC v6 12/14] softmmu: Simplify helper_*_st_name, wrap RAM code, Alvise Rigo, 2015/12/14