Re: [Qemu-devel] [PATCH 1/6] arm: use "struct ARMCPU" in header files

[Peter Maydell]

On 15 December 2015 at 14:28, Paolo Bonzini <address@hidden> wrote:
> This removes a dependency on cpu.h.  Since this is in most cases the
> _only_ dependency on cpu.h, removing it now makes it easier to
> disentangle qemu-common.h and cpu.h.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  hw/arm/strongarm.h          |  2 +-
>  include/hw/arm/arm.h        | 12 +++++++-----
>  include/hw/arm/exynos4210.h |  5 +++--
>  include/hw/arm/omap.h       |  4 +++-
>  include/hw/arm/pxa.h        |  8 +++++---
>  5 files changed, 19 insertions(+), 12 deletions(-)
>
> diff --git a/hw/arm/strongarm.h b/hw/arm/strongarm.h
> index 2893f94..d87e41d 100644
> --- a/hw/arm/strongarm.h
> +++ b/hw/arm/strongarm.h
> @@ -53,7 +53,7 @@ enum {
>  };
>
>  typedef struct {
> -    ARMCPU *cpu;
> +    struct ARMCPU *cpu;


Couldn't we just put the typedef in typedefs.h instead ?

thanks
-- PMM