[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/5] target-i386: kvm: Increase MSR_BUF_SIZE
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH 2/5] target-i386: kvm: Increase MSR_BUF_SIZE |
Date: |
Wed, 16 Dec 2015 17:06:43 -0200 |
We are dangerously close to the array limits in kvm_put_msrs()
and kvm_get_msrs(): with the default mcg_cap configuration, we
can set up to 148 MSRs in kvm_put_msrs(), and if we allow mcg_cap
to be changed, we can write up to 236 MSRs.
Use 4096 bytes for the buffer, that can hold 255 kvm_msr_entry
structs.
Signed-off-by: Eduardo Habkost <address@hidden>
---
target-i386/kvm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 660b2d9..1e82400 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -52,8 +52,9 @@
#define MSR_KVM_WALL_CLOCK 0x11
#define MSR_KVM_SYSTEM_TIME 0x12
-#define MSR_BUF_SIZE \
- (sizeof(struct kvm_msrs) + 150 * sizeof(struct kvm_msr_entry))
+/* A 4096-byte buffer can hold the 8-byte kvm_msrs header, plus
+ * 255 kvm_msr_entry structs */
+#define MSR_BUF_SIZE 4096
#ifndef BUS_MCEERR_AR
#define BUS_MCEERR_AR 4
--
2.1.0
- [Qemu-devel] [PATCH 0/5] target-i386: kvm: Increase MSR entry array limits, check for array overrun, Eduardo Habkost, 2015/12/16
- [Qemu-devel] [PATCH 1/5] target-i386: kvm: Allocate kvm_msrs struct once per VCPU, Eduardo Habkost, 2015/12/16
- [Qemu-devel] [PATCH 2/5] target-i386: kvm: Increase MSR_BUF_SIZE,
Eduardo Habkost <=
- [Qemu-devel] [PATCH 4/5] target-i386: kvm: Simplify MSR setting functions, Eduardo Habkost, 2015/12/16
- [Qemu-devel] [PATCH 3/5] target-i386: kvm: Simplify MSR array construction, Eduardo Habkost, 2015/12/16
- [Qemu-devel] [PATCH 5/5] target-i386: kvm: Eliminate kvm_msr_entry_set(), Eduardo Habkost, 2015/12/16
- Re: [Qemu-devel] [PATCH 0/5] target-i386: kvm: Increase MSR entry array limits, check for array overrun, Paolo Bonzini, 2015/12/16