[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] coverity: Model g_poll()
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2] coverity: Model g_poll() |
Date: |
Thu, 17 Dec 2015 09:38:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 17/12/2015 08:20, Markus Armbruster wrote:
> In my testing, Coverity reported two more CHECKED_RETURN:
>
> * qemu-char.c:1248: fixed in commit c1f2448: "qemu-char: retry g_poll
> on EINTR".
>
> * migration/qemu-file-unix.c:75: harmless, cleaned up in commit
> 4e39f57 "migration: Clean up use of g_poll() in
> socket_writev_buffer()
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> v2: Commit message body rewritten, because fixes have been committed
> meanwhile.
Applied, thanks!
Paolo
> scripts/coverity-model.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/scripts/coverity-model.c b/scripts/coverity-model.c
> index e1d5f45..ee5bf9d 100644
> --- a/scripts/coverity-model.c
> +++ b/scripts/coverity-model.c
> @@ -342,6 +342,15 @@ char *g_strconcat(const char *s, ...)
>
> /* Other glib functions */
>
> +typedef struct pollfd GPollFD;
> +
> +int poll();
> +
> +int g_poll (GPollFD *fds, unsigned nfds, int timeout)
> +{
> + return poll(fds, nfds, timeout);
> +}
> +
> typedef struct _GIOChannel GIOChannel;
> GIOChannel *g_io_channel_unix_new(int fd)
> {
>