[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH untested] mirror: start drained section earlier
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH untested] mirror: start drained section earlier |
|
Date: |
Thu, 17 Dec 2015 10:04:05 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 17/12/2015 03:14, Fam Zheng wrote:
> @@ -388,7 +390,9 @@ static void mirror_exit(BlockJob *job, void *opaque)
> bdrv_unref(s->target);
> block_job_completed(&s->common, data->ret);
> g_free(data);
> - bdrv_drained_end(src);
> + if (drained_begin) {
> + bdrv_drained_end(src);
> + }
> bdrv_unref(src);
> }
>
> @@ -571,6 +575,7 @@ static void coroutine_fn mirror_run(void *opaque)
> */
> assert(QLIST_EMPTY(&bs->tracked_requests));
> s->common.cancelled = false;
> + s->drained_begin = true;
> break;
> }
> bdrv_drained_end(s->common.bs);
>
Good point, thanks!
Paolo