[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 43/45] scsi: always call notifier on async cancellati
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 43/45] scsi: always call notifier on async cancellation |
Date: |
Thu, 17 Dec 2015 18:46:39 +0100 |
This was found by code inspection. If the request is cancelled twice,
the notifier is never called on the second cancellation request,
and hence for example a TMF might never finish.
All the calls in scsi_req_cancel_async are idempotent, so the change
is safe.
Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
---
hw/scsi/scsi-bus.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
index a600074..00bddc9 100644
--- a/hw/scsi/scsi-bus.c
+++ b/hw/scsi/scsi-bus.c
@@ -1759,9 +1759,6 @@ void scsi_req_cancel_async(SCSIRequest *req, Notifier
*notifier)
if (notifier) {
notifier_list_add(&req->cancel_notifiers, notifier);
}
- if (req->io_canceled) {
- return;
- }
scsi_req_ref(req);
scsi_req_dequeue(req);
req->io_canceled = true;
--
2.5.0
- [Qemu-devel] [PULL 29/45] user: introduce "-d page", (continued)
- [Qemu-devel] [PULL 29/45] user: introduce "-d page", Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 32/45] exec: always call qemu_get_ram_ptr within rcu_read_lock, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 34/45] memory: reorder MemoryRegion fields, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 31/45] linux-user: convert DEBUG_SIGNAL logging to tracepoints, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 30/45] linux-user: avoid "naked" qemu_log, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 28/45] xtensa: avoid "naked" qemu_log, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 35/45] memory: avoid unnecessary object_ref/unref, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 40/45] rcu: optimize rcu_read_lock, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 37/45] memory: extract first iteration of address_space_read and address_space_write, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 41/45] target-i386: kvm: clear unusable segments' flags in migration, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 43/45] scsi: always call notifier on async cancellation,
Paolo Bonzini <=
- [Qemu-devel] [PULL 44/45] coverity: Model g_poll(), Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 33/45] exec: make qemu_ram_ptr_length more similar to qemu_get_ram_ptr, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 36/45] memory: split address_space_read and address_space_write, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 38/45] memory: inline a few small accessors, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 39/45] memory: try to inline constant-length reads, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 42/45] scsi: use scsi_req_cancel_async when purging requests, Paolo Bonzini, 2015/12/17
- [Qemu-devel] [PULL 45/45] coverity: Model g_memdup(), Paolo Bonzini, 2015/12/17