[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] iotests: Don't mention bdrv_swap in comment
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] iotests: Don't mention bdrv_swap in comments |
|
Date: |
Thu, 17 Dec 2015 20:07:12 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 17/12/2015 09:21, Kevin Wolf wrote:
>> > -# 'format': 'nbd' is not actually "correct", but this is probably the
>> > only way
>> > -# to test bdrv_swap() on an NBD BDS
>> > _send_qemu_cmd $QEMU_HANDLE \
>> > "{'execute': 'drive-mirror',
>> > 'arguments': {'device': 'src',
> Just completely removing the comment doesn't seem right to me if we
> leave the "bad" option around.
>
> The test seems to be a regression test for what was fixed in commit
> f53a829, i.e. a direct effect of bdrv_swap(). This effect can't exist
> any more, so we would keep the test just for some additional coverage
> for NBD. Do we still need 'format': 'nbd' (if so, with a comment why we
> do that) or should we make it 'raw' now?
Some coverage of no-format BDSes is nice to have, since raw is sometimes
measurably slower than no format at all.
Paolo