[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error string arguments (again) |
Date: |
Thu, 17 Dec 2015 13:57:05 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/17/2015 09:49 AM, Markus Armbruster wrote:
> Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they
> keep coming back. Tracked down with the Coccinelle semantic patch
> from commit 312fd5f.
Don't forget to rerun this to pick up stragglers exposed by 1/23 :)
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> Acked-by: Cornelia Huck <address@hidden>
> Acked-by: Bharata B Rao <address@hidden>
> Acked-by: Fam Zheng <address@hidden>
If you want to add to the list:
Reviewed-by: Eric Blake <address@hidden>
> +++ b/hw/s390x/s390-skeys.c
> @@ -191,8 +191,8 @@ static int qemu_s390_skeys_set(S390SKeysState *ss,
> uint64_t start_gfn,
> /* Check for uint64 overflow and access beyond end of key data */
> if (start_gfn + count > skeydev->key_count || start_gfn + count < count)
> {
> error_report("Error: Setting storage keys for page beyond the end "
> - "of memory: gfn=%" PRIx64 " count=%" PRId64 "\n", start_gfn,
> - count);
> + "of memory: gfn=%" PRIx64 " count=%" PRId64,
> + start_gfn, count);
Do we want a separate patch cleaning up 'Error: ' prefixes?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/23] Error reporting cleanups and fixes, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 03/23] error: Use error_report_err() instead of monitor_printf(), Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 02/23] error: Use error_report_err() where appropriate (again), Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error string arguments (again), Markus Armbruster, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error string arguments (again),
Eric Blake <=
- [Qemu-devel] [PATCH v2 06/23] block: Clean up "Could not create temporary overlay" error message, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Markus Armbruster, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Eric Blake, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Markus Armbruster, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Eric Blake, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Markus Armbruster, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Eric Blake, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Markus Armbruster, 2015/12/18