|
From: | Markus Armbruster |
Subject: | Re: [Qemu-devel] [PATCH v2 17/23] vmdk: Clean up control flow in vmdk_parse_extents() a bit |
Date: | Fri, 18 Dec 2015 10:54:44 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes: > On 12/17/2015 09:49 AM, Markus Armbruster wrote: >> Cc: Fam Zheng <address@hidden> >> Signed-off-by: Markus Armbruster <address@hidden> >> --- >> block/vmdk.c | 28 +++++++++++++++------------- >> 1 file changed, 15 insertions(+), 13 deletions(-) > > Could have mentioned what the change was: factoring out a common > next_line() helper to let you drop an end-of-loop label. Adding: Factor out loop stepping to turn a while-loop with goto into a for-loop with continue. > Reviewed-by: Eric Blake <address@hidden> Thanks!
[Prev in Thread] | Current Thread | [Next in Thread] |