Re: [Qemu-devel] [PATCH v2 21/23] error: Clean up errors with embedded newlines (again)

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 12/17/2015 09:50 AM, Markus Armbruster wrote:
>> The arguments of error_report() should yield a short error string
>> without newlines.
>> 
>> A few places try to print additional help after the error message by
>> embedding newlines in the error string.  That's nice, but let's do it
>> the right way.  Commit 474c213 cleaned up some, but they keep coming
>> back.  Offenders tracked down with the Coccinelle semantic patch from
>> commit 312fd5f.
>
> Not sure if you'll have any stragglers from 1/23 here, after fixing 16/23.

Just one:
    qemu-nbd.c:604:28:"Invalid number of argument.\n" "Try `%s --help' for more 
information."

>> 
>> Cc: Laszlo Ersek <address@hidden>
>> Cc: Pavel Fedin <address@hidden>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Laszlo Ersek <address@hidden>
>> ---
>>  hw/i386/pc.c | 4 ++--
>>  kvm-all.c    | 6 +++---
>>  2 files changed, 5 insertions(+), 5 deletions(-)
>> 
>
> Reviewed-by: Eric Blake <address@hidden>

Thanks!