[Qemu-devel] [PATCH v3 00/24] Error reporting cleanups and fixes

[Markus Armbruster]

Two topics:

1. Avoid error_get_pretty() when all you want is extend an error
message.  Doing that with error_get_pretty() loses the error hint.
Provide that don't lose it, and are more convenient to use.

2. Newlines in error messages.  Jason Herne's "[PATCH v2] checkpatch:
Detect newlines in error_report and other error functions" will catch
at least some instances of this kind of mistake in the future.

Based on my "[PATCH v3 00/13] Clean up some hw_error() misuse".

I intend to take these patches through my tree.

v3:
* PATCH 01+11: Commit messages improved, bad Coccinelle like breaks
  cleaned up [Eric]
* PATCH 02-04+09+12-14+17: Commit messages improved [Eric]
* PATCH 05: Cover a bit more ground in comments [Eric]
* PATCH 16+21: Fix three more instances [Eric]
* PATCH 18: Style fix [Fam]
* PATCH 24: New
v2:
* 19 new patches...
* PATCH 1 became PATCH 16
* PATCH 2 became PATCH 21, with commit message typo fixed [László]
* PATCH 3 split into PATCH 17-20, partly rewritten
* PATCH 4 became PATCH 22

Markus Armbruster (24):
  qemu-nbd: Replace BSDism <err.h> by error_report()
  error: Use error_report_err() where appropriate (again)
  error: Use error_report_err() instead of monitor_printf()
  error: Use error_report_err() instead of ad hoc prints
  error: Improve documentation
  block: Clean up "Could not create temporary overlay" error message
  qemu-nbd: Clean up "Failed to load snapshot" error message
  test-throttle: Simplify qemu_init_main_loop() error handling
  error: New error_prepend(), error_reportf_err()
  error: Don't decorate original error message when adding to it
  error: Use error_reportf_err() where it makes obvious sense
  error: Use error_prepend() where it makes obvious sense
  spapr: Use error_reportf_err()
  migration: Use error_reportf_err() instead of monitor_printf()
  qemu-io qemu-nbd: Use error_report() etc. instead of fprintf()
  error: Strip trailing '\n' from error string arguments (again)
  vmdk: Clean up control flow in vmdk_parse_extents() a bit
  vmdk: Clean up "Invalid extent lines" error message
  pci-assign: Clean up "Failed to assign" error messages
  vhdx: Fix "log that needs to be replayed" error message
  error: Clean up errors with embedded newlines (again)
  hw/s390x: Rename local variables Error *l_err to just err
  s390/sclp: Simplify control flow in sclp_realize()
  error: Consistently name Error * objects err, and not errp

 arch_init.c                        |   4 +-
 block.c                            |  20 +++---
 block/qcow2.c                      |   5 +-
 block/qed.c                        |   5 +-
 block/sheepdog.c                   |   8 +--
 block/vhdx-log.c                   |  13 ++--
 block/vmdk.c                       |  50 +++++++++------
 blockdev.c                         |  12 ++--
 contrib/ivshmem-server/main.c      |  10 ++-
 hmp.c                              |  61 ++++++++----------
 hw/arm/cubieboard.c                |   9 ++-
 hw/arm/digic_boards.c              |   3 +-
 hw/arm/imx25_pdk.c                 |   2 +-
 hw/arm/kzm.c                       |   2 +-
 hw/arm/netduino2.c                 |   2 +-
 hw/arm/xlnx-ep108.c                |   2 +-
 hw/arm/xlnx-zynqmp.c               |   2 +-
 hw/block/dataplane/virtio-blk.c    |   8 +--
 hw/core/nmi.c                      |  10 +--
 hw/core/qdev-properties.c          |   6 +-
 hw/core/qdev.c                     |   5 +-
 hw/i386/kvm/pci-assign.c           |  16 ++---
 hw/i386/pc.c                       |   9 ++-
 hw/ppc/e500.c                      |   4 +-
 hw/ppc/spapr.c                     |  10 +--
 hw/ppc/spapr_drc.c                 |   6 +-
 hw/s390x/ipl.c                     |  12 ++--
 hw/s390x/s390-skeys-kvm.c          |   2 +-
 hw/s390x/s390-skeys.c              |  19 +++---
 hw/s390x/sclp.c                    |  21 +++---
 hw/scsi/vhost-scsi.c               |   6 +-
 hw/tpm/tpm_tis.c                   |   2 +-
 hw/usb/bus.c                       |  11 ++--
 include/qapi/error.h               |  51 +++++++++++++--
 include/qemu/sockets.h             |   2 +-
 kvm-all.c                          |   6 +-
 migration/ram.c                    |   2 +-
 migration/savevm.c                 |  21 +++---
 monitor.c                          |   6 +-
 net/vhost-user.c                   |   6 +-
 qdev-monitor.c                     |   3 +-
 qemu-img.c                         |  33 ++++------
 qemu-io.c                          |   8 +--
 qemu-nbd.c                         | 128 ++++++++++++++++++++++---------------
 qga/commands-posix.c               |   2 +-
 replay/replay.c                    |   3 +-
 target-arm/cpu.c                   |   2 +-
 target-arm/machine.c               |   4 +-
 tests/qemu-iotests/059.out         |  12 ++--
 tests/qemu-iotests/060.out         |   2 +-
 tests/qemu-iotests/069.out         |   2 +-
 tests/qemu-iotests/070.out         |   5 +-
 tests/qemu-iotests/075.out         |  14 ++--
 tests/qemu-iotests/076.out         |   6 +-
 tests/qemu-iotests/078.out         |  12 ++--
 tests/qemu-iotests/080.out         |  36 +++++------
 tests/qemu-iotests/083.out         |  34 +++++-----
 tests/qemu-iotests/088.out         |  12 ++--
 tests/qemu-iotests/092.out         |  24 +++----
 tests/qemu-iotests/103.out         |   8 +--
 tests/qemu-iotests/114.out         |   2 +-
 tests/qemu-iotests/116.out         |  14 ++--
 tests/qemu-iotests/131.out         |   2 +-
 tests/test-aio.c                   |   4 +-
 tests/test-string-output-visitor.c |   6 +-
 tests/test-thread-pool.c           |   4 +-
 tests/test-throttle.c              |  15 +----
 ui/vnc.c                           |   4 +-
 util/error.c                       |  35 +++++++++-
 util/qemu-error.c                  |   8 +--
 vl.c                               |   8 +--
 71 files changed, 467 insertions(+), 436 deletions(-)

-- 
2.4.3