Re: [Qemu-devel] [PATCH 08/12] Support for N25Q256A/N25Q512A

[Peter Crosthwaite]

On Wed, Dec 16, 2015 at 4:57 AM,  <address@hidden> wrote:
> From: Marcin Krzeminski <address@hidden>
>
> Signed-off-by: Marcin Krzeminski <address@hidden>
> ---
>  hw/block/m25p80.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index f0f637e..a41c2f1 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -214,6 +214,8 @@ static const FlashPartInfo known_devices[] = {
>
>      /* Numonyx -- n25q128 */

Comment needs update to qXXX or just drop the part name altogether for:

/* Numonyx */

Otherwise:

Reviewed-by: Peter Crosthwaite <address@hidden>

Regards,
Peter

>      { INFO("n25q128",      0x20ba18,      0,  64 << 10, 256, 0) },
> +    { INFO("n25q256a",     0x20ba19,      0,  64 << 10, 512, ER_4K) },
> +    { INFO("n25q512a",     0x20ba20,      0,  64 << 10, 1024, ER_4K) },
>  };
>
>  typedef enum {
> --
> 2.5.0
>
>