Re: [Qemu-devel] [PATCH 04/12] Changed variable type to allow serial eeprom emulation (changing 0->1).

[Peter Crosthwaite]

Your commit message subject line should be a little shorter and
lengthier explanations of the patch content go here as a paragraph.
You should also have subsystem prefixes to patch subject lines. This
patch would be something like:

block: m25p80: widen flags variable

Extend the width of the flags variable to support the already existing
(but unused) WR_1 flag, which is above the range of 8 bits. This is
turn allows support of EEPROM emulation which requires the WR_1
feature.

On Wed, Dec 16, 2015 at 4:57 AM,  <address@hidden> wrote:
> From: Marcin Krzeminski <address@hidden>
>
> Signed-off-by: Marcin Krzeminski <address@hidden>

Otherwise:

Reviewed-by: Peter Crosthwaite <address@hidden>

Regards,
Peter

> ---
>  hw/block/m25p80.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index 5e07b57..fbbfd1d 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -60,7 +60,7 @@ typedef struct FlashPartInfo {
>      uint32_t sector_size;
>      uint32_t n_sectors;
>      uint32_t page_size;
> -    uint8_t flags;
> +    uint16_t flags;
>  } FlashPartInfo;
>
>  /* adapted from linux */
> --
> 2.5.0
>
>