[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize() |
Date: |
Mon, 21 Dec 2015 16:49:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 20/12/2015 12:38, Cao jin wrote:
>>>
>>> + object_unref(OBJECT(ds));
>>> + object_unref(OBJECT(bds));
>>> + object_unref(OBJECT(bus));
>>
>> I think these should be object_unparent, not unref.
>>
>
> But, it seems these 3 objects isn`t added as a child-property via
> object_property_add_child() during creation, so OBJECT(ds)->parent(so
> does the other 2) will be NULL, and so object_unparent will do nothing?
qdev_init_nofail adds them (qdev_init_nofail -> object_property_set_bool
-> device_set_realized -> object_property_add_child).
If you haven't reached qdev_init_nofail, you should indeed unref ds and
bds instead. However, the bus should be unparented because pci_bus_new
makes it a child of ds (pci_bus_new -> qbus_create -> qbus_realize ->
object_property_add_child).
Paolo
- Re: [Qemu-devel] [PATCH 5/5] xen-pvdevice: convert to realize(), (continued)
[Qemu-devel] [PATCH 4/5] gt64120: convert to realize(), Cao jin, 2015/12/18
[Qemu-devel] [PATCH 3/5] PXB: convert to realize(), Cao jin, 2015/12/18
- Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize(), Paolo Bonzini, 2015/12/18
- Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize(), Cao jin, 2015/12/20
- Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize(), Cao jin, 2015/12/21
- Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize(),
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize(), Cao jin, 2015/12/21
- Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize(), Marcel Apfelbaum, 2015/12/22
- Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize(), Cao jin, 2015/12/22
- Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize(), Marcel Apfelbaum, 2015/12/22
- Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize(), Cao jin, 2015/12/22
- Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize(), Cao jin, 2015/12/22
Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize(), Marcel Apfelbaum, 2015/12/20