[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] char: don't assume telnet initialization
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] char: don't assume telnet initialization will not block |
|
Date: |
Mon, 21 Dec 2015 17:01:08 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 21/12/2015 16:42, Daniel P. Berrange wrote:
> + ret = qio_channel_write(ioc, init->buf, init->buflen, NULL);
> + if (ret < 0) {
> + if (ret == QIO_CHANNEL_ERR_BLOCK) {
> + ret = 0;
> + } else {
> + tcp_chr_disconnect(init->chr);
> + return FALSE;
> + }
> + }
> + init->buflen -= ret;
Isn't an "init->buf += ret" missing here?
Paolo
> +