[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] char: don't assume telnet initialization
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] char: don't assume telnet initialization will not block |
|
Date: |
Mon, 21 Dec 2015 16:19:50 +0000 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Dec 21, 2015 at 05:01:08PM +0100, Paolo Bonzini wrote:
>
>
> On 21/12/2015 16:42, Daniel P. Berrange wrote:
> > + ret = qio_channel_write(ioc, init->buf, init->buflen, NULL);
> > + if (ret < 0) {
> > + if (ret == QIO_CHANNEL_ERR_BLOCK) {
> > + ret = 0;
> > + } else {
> > + tcp_chr_disconnect(init->chr);
> > + return FALSE;
> > + }
> > + }
> > + init->buflen -= ret;
>
> Isn't an "init->buf += ret" missing here?
Opps yes. Well not quite that since 'buf' is an array rather than
a pointer, but something equivalent. Anyway will fix it...
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|