[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] crypto: move QCryptoCipherAlgorithm/Mode en
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] crypto: move QCryptoCipherAlgorithm/Mode enum definitions into QAPI |
Date: |
Mon, 21 Dec 2015 09:29:40 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/21/2015 09:06 AM, Daniel P. Berrange wrote:
> The QCryptoCipherAlgorithm and QCryptoCipherMode enums are
> defined in the crypto/cipher.h header. In the future some
> QAPI types will want to reference the hash enums, so move
> the enum definition into QAPI too.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> crypto/cipher.c | 8 ++++----
> include/crypto/cipher.h | 17 ++---------------
> qapi/crypto.json | 30 ++++++++++++++++++++++++++++++
> 3 files changed, 36 insertions(+), 19 deletions(-)
>
> diff --git a/crypto/cipher.c b/crypto/cipher.c
> index d02bb32..e92d49a 100644
> --- a/crypto/cipher.c
> +++ b/crypto/cipher.c
> @@ -21,21 +21,21 @@
> #include "crypto/cipher.h"
>
>
> -static size_t alg_key_len[QCRYPTO_CIPHER_ALG_LAST] = {
> +static size_t alg_key_len[QCRYPTO_CIPHER_ALG_MAX] = {
Will need rebasing, now that commit 7fb1cf1 has landed and renamed it
QCRYPTO_CIPHER_ALG__MAX.
Otherwise looks fine.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/6] Misc enhancements to crypto APIs, Daniel P. Berrange, 2015/12/21
- [Qemu-devel] [PATCH 1/6] crypto: add ability to query the cipher key, block & IV lens, Daniel P. Berrange, 2015/12/21
- [Qemu-devel] [PATCH 2/6] crypto: add ability to query hash digest len, Daniel P. Berrange, 2015/12/21
- [Qemu-devel] [PATCH 4/6] crypto: move QCryptoCipherAlgorithm/Mode enum definitions into QAPI, Daniel P. Berrange, 2015/12/21
- Re: [Qemu-devel] [PATCH 4/6] crypto: move QCryptoCipherAlgorithm/Mode enum definitions into QAPI,
Eric Blake <=
- [Qemu-devel] [PATCH 5/6] crypto: ensure qapi/crypto.json is listed in qapi-modules, Daniel P. Berrange, 2015/12/21
- [Qemu-devel] [PATCH 6/6] crypto: fix transposed arguments in cipher error message, Daniel P. Berrange, 2015/12/21
- [Qemu-devel] [PATCH 3/6] crypto: move QCryptoHashAlgorithm enum definition into QAPI, Daniel P. Berrange, 2015/12/21