[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ivshmem: remove redundant assignment, fix crash
|
From: |
P J P |
|
Subject: |
Re: [Qemu-devel] [PATCH] ivshmem: remove redundant assignment, fix crash with msi=off |
|
Date: |
Tue, 22 Dec 2015 00:40:26 +0530 (IST) |
+-- On Mon, 21 Dec 2015, address@hidden wrote --+
| diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
| index 7d14222..dcfc8cc 100644
| --- a/hw/misc/ivshmem.c
| +++ b/hw/misc/ivshmem.c
| @@ -355,12 +355,9 @@ static CharDriverState*
create_eventfd_chr_device(IVShmemState *s,
| int vector)
| {
| /* create a event character device based on the passed eventfd */
| - PCIDevice *pdev = PCI_DEVICE(s);
| int eventfd = event_notifier_get_fd(n);
| CharDriverState *chr;
|
| - s->msi_vectors[vector].pdev = pdev;
| -
| chr = qemu_chr_open_eventfd(eventfd);
|
| if (chr == NULL) {
Looks okay.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F