qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/7] qom: add user_creatable_add & user_creatabl


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 1/7] qom: add user_creatable_add & user_creatable_del methods
Date: Tue, 22 Dec 2015 09:01:58 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 12/22/2015 04:06 AM, Daniel P. Berrange wrote:
> The QMP monitor code has two helper methods object_add
> and qmp_object_del that are called from several places
> in the code (QMP, HMP and main emulator startup).
> 
> We soon need to use this code from qemu-img, qemu-io
> and qemu-nbd too, but don't want those to depend on
> the monitor.
> 
> To avoid this, move object_add to user_creatable_add
> an qmp_object_del to user_creatable_del, to the
> object_interfaces.c file where they can be easily
> shared with all users of QOM
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  hmp.c                           | 11 ++++--
>  include/monitor/monitor.h       |  3 --
>  include/qom/object_interfaces.h | 31 +++++++++++++++++
>  qmp.c                           | 75 ++++------------------------------------
>  qom/object_interfaces.c         | 76 
> +++++++++++++++++++++++++++++++++++++++++
>  vl.c                            |  8 +++--
>  6 files changed, 127 insertions(+), 77 deletions(-)

Looks like fairly straightforward code motion.
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]