qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set o


From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args
Date: Wed, 23 Dec 2015 16:55:53 +0000
User-agent: Mutt/1.5.24 (2015-08-30)

On Tue, Dec 22, 2015 at 11:10:27AM -0700, Eric Blake wrote:
> On 12/22/2015 11:07 AM, Daniel P. Berrange wrote:
> 
> > A third option would be to keep using positional arguments, but
> > add a '--source-opts' *boolean* flag to indicate how to interpret
> > the positional arguments.  ie without --source-opts we use the
> > historic syntax, but with --source-opts, we assume the full QemuOpts
> > syntax.
> 
> Oh, nice compromise. It's relatively discoverable (grep --help output),
> preserves back-compat of old scripts, and offers the full power for
> clients that want the full power.

I've implemented this now and it makes the patches soooo much simpler
too, so an added win.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]