Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

[Roman Kagan]

On Wed, Dec 23, 2015 at 06:47:16PM +0100, Igor Mammedov wrote:
> On Wed, 23 Dec 2015 20:20:54 +0300
> Roman Kagan <address@hidden> wrote:
> > > ... two 1.44M drives with bogus geometry for q35.
> > 
> > This one is a bug in my patch, indeed: I was tricked by FDRIVE_DRV_NONE
> > being non-zero, and forgot to initialize the respective fields in
> > acpi_get_misc_info() in case there is no floppy controller at all.
> so instead of fake initialization, it's worth to make your patch
> conditional on presence of controller after all.
> i.e. add AML only if controller was present.

Indeed :)

Roman.