[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration |
|
Date: |
Thu, 24 Dec 2015 01:21:10 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 24.12.2015 01:15, Max Reitz wrote:
> On 23.12.2015 05:12, Fam Zheng wrote:
>> The "pnum < nb_sectors" condition in deciding whether to actually copy
>> data is unnecessarily strict, and the qiov initialization is
>> unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard.
>>
>> Rewrite mirror_iteration to fix both flaws.
>>
>> Signed-off-by: Fam Zheng <address@hidden>
>> ---
>> block/mirror.c | 308
>> +++++++++++++++++++++++++++++++++++----------------------
>> 1 file changed, 188 insertions(+), 120 deletions(-)
>
> Reviewed-by: Max Reitz <address@hidden>
Forgot to note: I think this patch needs a rebase already.
Max
signature.asc
Description: OpenPGP digital signature