Re: [Qemu-devel] [PATCH] linux-user/mmap.c: Use end instead of real_end in target_mmap

[Chen Gang]

Hello all:

After this patch, the i386 wine notepad.exe can be bootup and run under
sw_64 host.

 - The initialization is very very slow (about 10 minutes), it is mainly
   running in find_vma_reserved (consume more than 95% time resource). I
   guess, it can be optimized.

 - After initialization, for real using, the performance is acceptable!!
   :-)

 - Next, I shall try the real Windows XP notepad.exe.

I guess, we need not softmmu, at least, for wine, it is true (wine will
mmap all memory areas during initializing, and manage them by itself
when real running).

Welcome any suggestions, ideas, and completions.


BTW: Merry Christmas!  :-)

Thanks.

On 2015年12月24日 09:07, address@hidden wrote:
> From: Chen Gang <address@hidden>
> 
> In this case, real_end is larger than end, which may cause mmap_frag
> process the incorrect memory region.
> 
> Signed-off-by: Chen Gang <address@hidden>
> ---
>  linux-user/mmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> index 7b459d5..57b0361 100644
> --- a/linux-user/mmap.c
> +++ b/linux-user/mmap.c
> @@ -536,7 +536,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int 
> prot,
>          /* handle the end of the mapping */
>          if (end < real_end) {
>              ret = mmap_frag(real_end - qemu_host_page_size,
> -                            real_end - qemu_host_page_size, real_end,
> +                            real_end - qemu_host_page_size, end,
>                              prot, flags, fd,
>                              offset + real_end - qemu_host_page_size - start);
>              if (ret == -1)
> 

-- 
Chen Gang (陈刚)

Open, share, and attitude like air, water, and life which God blessed