[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/4] target-tilegx: Add floating point shared
From: |
Chen Gang |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/4] target-tilegx: Add floating point shared functions |
Date: |
Fri, 25 Dec 2015 21:05:14 +0800 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 12/25/15 04:01, Richard Henderson wrote:
> On 12/24/2015 07:38 AM, Chen Gang wrote:
>>
>> OK, thanks. Since fp_status need to be initialized to be 0, so I will
>> declared it statically, too (need we consider about thread safe for it?
>> I guess not).
>
> While qemu is not currently thread-safe, there's work going on to make that
> happen. There is no need to exacerbate the problem.
>
OK, thanks.
> Also, I think using an on-stack automatic variable, initialized each time,
> emphasizes the fact there there is no state that is preserved across
> operations.
>
> This should really be as simple as
>
> float_status fp_status = {
> .float_rounding_mode = float_round_nearest_even
> };
>
> (I realize float_round_nearest_even is *also* zero, but humor me. At least
> the other members are either flags or booleans.)
>
OK, thanks.
--
Chen Gang (陈刚)
Open, share, and attitude like air, water, and life which God blessed