qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] linux-user/mmap.c: Always zero MAP_ANONYMOUS


From: Chen Gang
Subject: Re: [Qemu-devel] [PATCH v3] linux-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag()
Date: Thu, 31 Dec 2015 21:10:20 +0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 12/30/15 09:14, Laurent Vivier wrote:
> 
> Le 30/12/2015 02:10, address@hidden a écrit :
>> From: Chen Gang <address@hidden>
>>
>> When mapping MAP_ANONYMOUS memory fragments, still need notice about to
>> set it zero, or it will cause issues.
>>
>> Signed-off-by: Chen Gang <address@hidden>
>> ---
>>  linux-user/mmap.c |    4 +++-
>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
>> index 7b459d5..c6c478e 100644
>> --- a/linux-user/mmap.c
>> +++ b/linux-user/mmap.c
>> @@ -186,10 +186,12 @@ static int mmap_frag(abi_ulong real_start,
>>          if (prot_new != (prot1 | PROT_WRITE))
>>              mprotect(host_start, qemu_host_page_size, prot_new);
>>      } else {
>> -        /* just update the protection */
>>          if (prot_new != prot1) {
>>              mprotect(host_start, qemu_host_page_size, prot_new);
>>          }
>> +        if (prot_new & PROT_WRITE) {
>> +            memset(g2h(start), 0, end - start);
>> +        }
>>      }
>>      return 0;
>>  }
>>
> 
> Reviewed-by: Laurent Vivier <address@hidden>
> 

Thank you for your work.


Happy New Year!  :-)

-- 
Chen Gang (陈刚)

Open, share, and attitude like air, water, and life which God blessed



reply via email to

[Prev in Thread] Current Thread [Next in Thread]