Re: [Qemu-devel] [PATCH v3 0/3] sdhci patches to enable Raspberry Pi

[Andrew Baumann]

> From: Stefan Hajnoczi [mailto:address@hidden
> Sent: Tuesday, 22 December 2015 00:04
> On Mon, Dec 21, 2015 at 02:47:46PM -0800, Andrew Baumann wrote:
> > This is a series of three tweaks needed to enable the generic sdhci
> > controller to emulate Raspberry Pi (bcm2835/2836), and boot Linux and
> > Windows.
> >
> > There was some discussion of these changes in the following thread:
> > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01401.html
> >
> > v2 is functionally equivalent to v1; the only changes are to commit
> > messages and review metadata. v3 fixes two bugs in patch 3/3 (details
> > there).
> >
> > Cheers,
> > Andrew
> >
> > Andrew Baumann (2):
> >   sdhci: don't raise a command index error for an unexpected response
> >   sdhci: add optional quirk property to disable card insertion/removal
> >     interrupts
> >
> > Peter Crosthwaite (1):
> >   sd: sdhci: Delete over-zealous power check
> >
> >  hw/sd/sdhci.c         | 10 +++++-----
> >  include/hw/sd/sdhci.h |  1 +
> >  2 files changed, 6 insertions(+), 5 deletions(-)
> >
> > --
> > 2.5.3
> 
> I have merged SD Card patches in the past and this looks reasonable.  My
> SD Card knowledge is zero, however.  You have Reviewed-by from Peter
> Crosthwaithe so let's merge this.
> 
> Thanks, applied to my block-next tree:
> https://github.com/stefanha/qemu/commits/block-next

Thanks. Unfortunately I screwed up testing patch 3/3 (the sdhci noeject quirk, 
committed as 723697551a7e9), and it doesn't work as intended -- in fact, it 
serves no useful purpose in its present form. I'll send a new series shortly to 
back it out and replace it with a pi-specific quirk. 

(The other two patches from this series are still good, BTW.)

Andrew