[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] net: ne2000: fix bounds check in ioport oper
From: |
P J P |
Subject: |
Re: [Qemu-devel] [PATCH v3] net: ne2000: fix bounds check in ioport operations |
Date: |
Mon, 4 Jan 2016 14:36:00 +0530 (IST) |
+-- On Mon, 4 Jan 2016, Jason Wang wrote --+
| > + if (addr < 32
| > + || (addr >= NE2000_PMEM_START
| > + && addr + sizeof(uint32_t) - 1 < NE2000_MEM_SIZE)) {
| > return ldl_le_p(s->mem + addr);
| > } else {
| > return 0xffffffff;
|
| Applied to my -net with minor tweaks:
|
| Change "addr + sizeof(uint32_t) - 1 < NE2000_MEM_SIZE" to "addr +
| sizeof(uint32_t) <= NE2000_MEM_SIZE".
Okay, thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F