qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: debug printf fixups


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: debug printf fixups
Date: Tue, 5 Jan 2016 07:07:22 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0

On 01/05/2016 06:22 AM, Andrew Jones wrote:
> (Found by grepping for broken PRI users.)
> 
> Signed-off-by: Andrew Jones <address@hidden>
> ---
>  hw/dma/xilinx_axidma.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c
> index b1cfa11356a26..2ab0772cd19ae 100644
> --- a/hw/dma/xilinx_axidma.c
> +++ b/hw/dma/xilinx_axidma.c
> @@ -180,10 +180,10 @@ static inline int streamid_from_addr(hwaddr addr)
>  #ifdef DEBUG_ENET
>  static void stream_desc_show(struct SDesc *d)
>  {
> -    qemu_log("buffer_addr  = " PRIx64 "\n", d->buffer_address);
> -    qemu_log("nxtdesc      = " PRIx64 "\n", d->nxtdesc);
> -    qemu_log("control      = %x\n", d->control);
> -    qemu_log("status       = %x\n", d->status);
> +    qemu_log("buffer_addr  = 0x%" PRIx64 "\n", d->buffer_address);
> +    qemu_log("nxtdesc      = 0x%" PRIx64 "\n", d->nxtdesc);
> +    qemu_log("control      = 0x%x\n", d->control);
> +    qemu_log("status       = 0x%x\n", d->status);

This is dead code.  Nothing uses stream_desc_show() even when DEBUG_ENET
is defined.  I'd just delete the function and #ifdef altogether, instead.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]