[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/3] virtio: cross-endian helpers fixes
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/3] virtio: cross-endian helpers fixes |
Date: |
Wed, 6 Jan 2016 13:09:27 +0200 |
On Tue, Jan 05, 2016 at 08:19:22PM +0100, Greg Kurz wrote:
> On Wed, 23 Dec 2015 17:28:23 +0100
> Greg Kurz <address@hidden> wrote:
>
> > On Wed, 23 Dec 2015 15:47:00 +0200
> > "Michael S. Tsirkin" <address@hidden> wrote:
> >
> > > On Thu, Dec 17, 2015 at 09:52:46AM +0100, Greg Kurz wrote:
> > > > This series tries to rework cross-endian helpers for better clarity.
> > > > It does not change behaviour, except perhaps patch 3/3 even if I could
> > > > not
> > > > measure any performance gain.
> > >
> > > Breaks build:
> > >
> > > CC mips64-softmmu/hw/mips/mips_malta.o
> > > /home/mst/scm/qemu/hw/net/vhost_net.c: In function
> > > ‘vhost_net_set_vnet_endian’:
> > > /home/mst/scm/qemu/hw/net/vhost_net.c:208:10: error: implicit
> > > declaration of function ‘virtio_legacy_is_cross_endian’
> > > [-Werror=implicit-function-declaration]
> > > (virtio_legacy_is_cross_endian(dev) &&
> > > !virtio_is_big_endian(dev))) {
> > > ^
> > > /home/mst/scm/qemu/hw/net/vhost_net.c:208:9: error: nested extern
> > > declaration of ‘virtio_legacy_is_cross_endian’ [-Werror=nested-externs]
> > > (virtio_legacy_is_cross_endian(dev) &&
> > > !virtio_is_big_endian(dev))) {
> > > ^
> > > cc1: all warnings being treated as errors
> > > /home/mst/scm/qemu/rules.mak:57: recipe for target 'hw/net/vhost_net.o'
> > > failed
> > > make[1]: *** [hw/net/vhost_net.o] Error 1
> > > Makefile:186: recipe for target 'subdir-i386-softmmu' failed
> > > make: *** [subdir-i386-softmmu] Error 2
> > >
> > >
> > > please always build all architectures.
> > >
> >
> > Ok. I'll do so from now on.
> >
>
> The break isn't architecture related actually. It is because this series
> depends on the "virtio-net/vhost-net: share cross-endian enablement" series
> I had posted before... my bad. Since most of these series is cleanup of the
> cross-endian code,
Oh. And I thought it's the reverse order somehow.
> I'll repost a single series with all the patches.
That's probably best.
> > > > ---
> > > >
> > > > Greg Kurz (3):
> > > > virtio: move cross-endian helper to vhost
> > > > vhost: move virtio 1.0 check to cross-endian helper
> > > > virtio: optimize virtio_access_is_big_endian() for little-endian
> > > > targets
> > > >
> > > >
> > > > hw/virtio/vhost.c | 22 ++++++++++++++++++----
> > > > include/hw/virtio/virtio-access.h | 16 +++-------------
> > > > 2 files changed, 21 insertions(+), 17 deletions(-)
> > >
> >
> >