[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 1/2] mirror: Rewrite mirror_iteration
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-devel] [PATCH v9 1/2] mirror: Rewrite mirror_iteration |
|
Date: |
Wed, 6 Jan 2016 18:57:29 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 05.01.2016 09:46, Fam Zheng wrote:
> The "pnum < nb_sectors" condition in deciding whether to actually copy
> data is unnecessarily strict, and the qiov initialization is
> unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard.
>
> Rewrite mirror_iteration to fix both flaws.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/mirror.c | 347
> +++++++++++++++++++++++++++++++++++----------------------
> trace-events | 1 -
> 2 files changed, 216 insertions(+), 132 deletions(-)
Side note: This breaks the output of iotest 109, probably due to
different alignment of the mirroring operations (doesn't look serious,
though).
Max
signature.asc
Description: OpenPGP digital signature