[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 24/34] scripts/kvm/kvm_stat: Cleanup of Event cl
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 24/34] scripts/kvm/kvm_stat: Cleanup of Event class |
|
Date: |
Thu, 7 Jan 2016 16:25:45 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 10/12/2015 13:12, Janosch Frank wrote:
> + event_data = {
> + 'cpu': cpu,
> + 'name': name,
> + 'group': group,
> + 'set': 'kvm',
> + 'tracepoint': tracepoint,
> + 'filter': tracefilter or None,
> + }
> + group.add_event(event_data)
I'd rather have the Event passed directly to add_event, and the event
constructor use keyword arguments instead of a dictionary.
Paolo
> self.group_leaders.append(group)
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 24/34] scripts/kvm/kvm_stat: Cleanup of Event class,
Paolo Bonzini <=