Re: [Qemu-devel] [PATCH 27/34] scripts/kvm/kvm_stat: Make tui function a class

[Paolo Bonzini]

On 10/12/2015 13:12, Janosch Frank wrote:
> +
> +def tui(screen, stats):
> +    interface = Tui(screen, stats)
> +    interface.show_stats()
>  

I think it would make sense to "reimplement" curses.wrapper as
__enter__/__exit__ methods in Tui(), and then use with here.

It's really just a bunch of curses calls:

        self.stdscr = curses.initscr()
        curses.noecho()
        curses.cbreak()

        # Start color, too.  Harmless if the terminal doesn't have
        # color; user can test with has_color() later on.  The try/catch
        # works around a minor bit of over-conscientiousness in the curses
        # module -- the error return from C start_color() is ignorable.
        try:
            curses.start_color()
        except:
            pass

        curses.use_default_colors()
---

        # Set everything back to normal
        if self.stdscr:
            self.stdscr.keypad(0)
            curses.echo()
            curses.nocbreak()
            curses.endwin()

where the existing calls to curses.use_default_colors and curses.noecho
can then be removed.

Paolo