Re: [Qemu-devel] [PATCH 20/34] scripts/kvm/kvm_stat: Cleanup cpu list retrieval

[Janosch Frank]

On 01/07/2016 04:21 PM, Paolo Bonzini wrote:
> 
> 
> On 10/12/2015 13:12, Janosch Frank wrote:
>> +    with open('/sys/devices/system/cpu/online') as cpu_list:
>> +        cpu_string = cpu_list.readline()
>> +        cpus = cpu_string.split(',')
>> +
>> +        for cpu in cpus:
>> +            if '-' not in cpu:
>> +                cpulist.append(int(cpu))
>> +            else:
>> +                cpu_range = cpu.split('-')
>> +                cpulist.extend(range(int(cpu_range[0]),
>> +                                     int(cpu_range[1]) + 1))
> 
> Perhaps you can move everything after readline() to a separate function?
> 
> Paolo
The string analysis to extract the cpu numbers is only needed in the
get_online_cpus function where it resides, so why do you want to split
this function into two?

Its also only a few lines which are easy to read.