Re: [Qemu-devel] [PATCH 09/22] 9pfs: remove dead code

[Paolo Bonzini]

On 07/01/2016 17:41, Aneesh Kumar K.V wrote:
>> > The function virtio_9p_set_fd_limit is unused.

It's not, it's called at startup by libc.

Paolo

>> > Signed-off-by: Wei Liu <address@hidden>
>> > ---
>> >  hw/9pfs/virtio-9p.c | 11 ---------
>> >  hw/9pfs/virtio-9p.h | 68 
>> > -----------------------------------------------------
>> >  2 files changed, 79 deletions(-)
>> >
>> > diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
>> > index 30ff828..084fa6a 100644
>> > --- a/hw/9pfs/virtio-9p.c
>> > +++ b/hw/9pfs/virtio-9p.c
>> > @@ -3287,14 +3287,3 @@ void handle_9p_output(VirtIODevice *vdev, VirtQueue 
>> > *vq)
>> >      }
>> >      free_pdu(s, pdu);
>> >  }
>> > -
>> > -static void __attribute__((__constructor__)) virtio_9p_set_fd_limit(void)
>> > -{
>> > -    struct rlimit rlim;
>> > -    if (getrlimit(RLIMIT_NOFILE, &rlim) < 0) {
>> > -        fprintf(stderr, "Failed to get the resource limit\n");
>> > -        exit(1);
>> > -    }
>> > -    open_fd_hw = rlim.rlim_cur - MIN(400, rlim.rlim_cur/3);
>> > -    open_fd_rc = rlim.rlim_cur/2;
>> > -}
> I am looking at when we stopped using that. We still do file descriptor
> reclaim. If we do that we need to set the open_fd_hw/rc.
> 
> 
>