[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/22] 9pfs: use V9fsBlob to transmit xattr
From: |
Wei Liu |
Subject: |
Re: [Qemu-devel] [PATCH 12/22] 9pfs: use V9fsBlob to transmit xattr |
Date: |
Thu, 7 Jan 2016 17:03:16 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jan 07, 2016 at 10:19:47PM +0530, Aneesh Kumar K.V wrote:
> Wei Liu <address@hidden> writes:
>
> > And make v9fs_pack static function. Now we only need to export
> > v9fs_{,un}marshal to device.
>
>
> Any advantage of doing this ? compared to v9fs_pack ?. Trying to
> understand if i am missing something here
>
The reason for exporting v9fs_pack is because there is no abstraction of
blob in marshalling interface. We should fix marshalling functions
instead of leaking v9fs_pack to device.
As said in the commit message, with this change now we only need to
export v9fs_marshal and v9fs_unmarshal to device. That's a much cleaner
interface.
Wei.
- [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, (continued)
- [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, Wei Liu, 2016/01/05
- Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, Aneesh Kumar K.V, 2016/01/07
- Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, Wei Liu, 2016/01/07
- Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, Aneesh Kumar K.V, 2016/01/07
- Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, Greg Kurz, 2016/01/07
- Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, Wei Liu, 2016/01/07
- Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, Wei Liu, 2016/01/07
[Qemu-devel] [PATCH 17/22] 9pfs: factor out virtio_pdu_{, un}marshal, Wei Liu, 2016/01/05
[Qemu-devel] [PATCH 12/22] 9pfs: use V9fsBlob to transmit xattr, Wei Liu, 2016/01/05
[Qemu-devel] [PATCH 13/22] fsdev: rename virtio-9p-marshal.{c, h} to 9p-iov-marshal.{c, h}, Wei Liu, 2016/01/05
[Qemu-devel] [PATCH 14/22] 9pfs: PDU processing functions don't need to take V9fsState as argument, Wei Liu, 2016/01/05
Re: [Qemu-devel] [PATCH 00/22] 9pfs: disentangling virtio and generic code, Stefano Stabellini, 2016/01/07
Re: [Qemu-devel] [PATCH 00/22] 9pfs: disentangling virtio and generic code, Aneesh Kumar K.V, 2016/01/07