qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 12/22] 9pfs: use V9fsBlob to transmit xattr


From: Wei Liu
Subject: Re: [Qemu-devel] [PATCH 12/22] 9pfs: use V9fsBlob to transmit xattr
Date: Thu, 7 Jan 2016 17:03:16 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Jan 07, 2016 at 10:19:47PM +0530, Aneesh Kumar K.V wrote:
> Wei Liu <address@hidden> writes:
> 
> > And make v9fs_pack static function. Now we only need to export
> > v9fs_{,un}marshal to device.
> 
> 
> Any advantage of doing this ? compared to v9fs_pack ?. Trying to
> understand if i am missing something here 
> 

The reason for exporting v9fs_pack is because there is no abstraction of
blob in marshalling interface. We should fix marshalling functions
instead of leaking v9fs_pack to device.

As said in the commit message, with this change now we only need to
export v9fs_marshal and v9fs_unmarshal to device. That's a much cleaner
interface.

Wei.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]