Re: [Qemu-devel] [PATCH 00/22] 9pfs: disentangling virtio and generic code

[Aneesh Kumar K.V]

Greg Kurz <address@hidden> writes:

> On Thu, 7 Jan 2016 11:59:22 +0000
> Stefano Stabellini <address@hidden> wrote:
>
>> On Tue, 5 Jan 2016, Wei Liu wrote:
>> > Hi all
>> > 
>> > Back in 2015 summer one of our OPW interns Linda Jacobson explored the
>> > possibility of making 9pfs work on Xen. It turned out lots of code in QEMU 
>> > can
>> > be reused.
>> > 
>> > This series refactors 9pfs related code:
>> > 
>> > 1. Rename a bunch of files and functions to make clear they are generic.
>> > 2. Only export two functions (marshal and unmarshal) from transport to 
>> > generic
>> >    code.
>> > 3. disentangle virtio transport code and generic 9pfs code.
>> > 4. Some function name clean-up.
>> 
>> The series looks pretty good and it looks like a clean improvement over
>> the current code base.
>> 
>
> I agree Wei did a great job. I'll fix the title in patch 3 and push it to
> my tree next week.
>

I will like to push this myself. I will need some time to get some
testing done with the changes. We also need some fixup with respect to fd
reclaim.

-aneesh