|
| From: | Aneesh Kumar K.V |
| Subject: | Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h} |
| Date: | Thu, 07 Jan 2016 22:58:28 +0530 |
| User-agent: | Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) |
Wei Liu <address@hidden> writes: > On Thu, Jan 07, 2016 at 10:27:13PM +0530, Aneesh Kumar K.V wrote: >> Wei Liu <address@hidden> writes: >> >> > The vast majority of code in virtio-9p.c is actually generic code. >> > Rename that file to 9p.c and move virtio specific code to >> > virtio-9p-device.c. Rename virtio-9p.h to 9p.h and split out virtio >> > specific code to new virtio-9p.h. >> > >> > Finally fix up virtio-pci.h header file inclusion. >> > >> > Note that V9fsState and V9fsPDU are still tied to virtio at the moment. >> > They will be handled later. >> >> Can you split this to smaller patches as done for others. >> > > I'm not sure what you're asking for. IMHO splitting out C and header > file is better done in one single commit. > virtio-9p.h -> 9p.h one patch virtio_p9_push_and_notify . There is one other instance of that conversion in the next patch handle_p9_output movement V9fsThPool, what is that ? -aneesh
| [Prev in Thread] | Current Thread | [Next in Thread] |