Re: [Qemu-devel] [PATCH 3/6] virtio: drop the virtio_needs_swap() helper

[Laurent Vivier]

On 07/01/2016 12:32, Greg Kurz wrote:
> It is not used anymore.
> 
> Signed-off-by: Greg Kurz <address@hidden>
> ---
>  include/hw/virtio/virtio-access.h |    9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/include/hw/virtio/virtio-access.h 
> b/include/hw/virtio/virtio-access.h
> index 8aec843c8ff3..a01fff2e51d7 100644
> --- a/include/hw/virtio/virtio-access.h
> +++ b/include/hw/virtio/virtio-access.h
> @@ -143,15 +143,6 @@ static inline uint64_t virtio_ldq_p(VirtIODevice *vdev, 
> const void *ptr)
>      }
>  }
>  
> -static inline bool virtio_needs_swap(VirtIODevice *vdev)
> -{
> -#ifdef HOST_WORDS_BIGENDIAN
> -    return virtio_access_is_big_endian(vdev) ? false : true;
> -#else
> -    return virtio_access_is_big_endian(vdev) ? true : false;
> -#endif
> -}
> -

I think you can move this to PATCH 1/6 too.

>  static inline uint16_t virtio_tswap16(VirtIODevice *vdev, uint16_t s)
>  {
>  #ifdef HOST_WORDS_BIGENDIAN
> 
>