Re: [Qemu-devel] [PATCH v2 13/21] block: Introduce bs->explicit_options

[Paolo Bonzini]

On 23/11/2015 16:59, Kevin Wolf wrote:
> +    bs->explicit_options = qdict_clone_shallow(options);

qdict_clone_shallow dereferences options, and other parts of
bdrv_open_inherit assume options != NULL.  You can remove the first part
of this condition, some 50 lines below:

    /* Check if any unknown options were used */
    if (options && (qdict_size(options) != 0)) {

Thanks,

Paolo
> +
>      if (child_role) {
>          bs->inherits_from = parent;
>          child_role->inherit_options(&flags, options,