[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/11] Ide patches
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 00/11] Ide patches |
Date: |
Mon, 11 Jan 2016 11:18:49 +0000 |
On 9 January 2016 at 00:51, John Snow <address@hidden> wrote:
> The following changes since commit 38a762fec63fd5c035aae29ba9a77d357e21e4a7:
>
> Merge remote-tracking branch
> 'remotes/berrange/tags/pull-crypto-fixes-2015-12-23-1' into staging
> (2015-12-23 13:53:32 +0000)
>
> are available in the git repository at:
>
> https://github.com/jnsnow/qemu.git tags/ide-pull-request
>
> for you to fetch changes up to 4160ad843841df21de296016fb77f986e693bed2:
>
> libqos/ahci: organize header (2016-01-08 15:22:34 -0500)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------
These seem to result in some new clang sanitizer runtime warnings
during a 'make check':
/home/petmay01/linaro/qemu-for-merges/tests/libqos/ahci.c:963:9:
runtime error: store to misaligned address 0x2adacfbaacd7 for type
'uint16_t' (aka 'unsigned short'), which requires 2 byte alignment
0x2adacfbaacd7: note: pointer points here
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 21
00 00 00 00 00 00 00 6c 6f 6e
^
/home/petmay01/linaro/qemu-for-merges/tests/libqos/ahci.c:907:9:
runtime error: store to misaligned address 0x2adacfbaacd2 for type
'uint32_t' (aka 'unsigned int'), which requires 4 byte alignment
0x2adacfbaacd2: note: pointer points here
00 00 28 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 21 00 00 00 00 00
^
This kind of thing:
unsigned char *cbd = cmd->atapi_cmd;
uint32_t *lba32;
lba32 = (uint32_t *)&(cbd[2]);
*lba32 = cpu_to_be32(lba);
isn't valid. You probably want
stl_be_p(&cbd[2], lba);
(defined in qemu/bswap.h).
thanks
-- PMM
- [Qemu-devel] [PULL 02/11] ide: ahci: reset ncq object to unused on error, (continued)
- [Qemu-devel] [PULL 02/11] ide: ahci: reset ncq object to unused on error, John Snow, 2016/01/08
- [Qemu-devel] [PULL 03/11] ahci-test: fix memory leak, John Snow, 2016/01/08
- [Qemu-devel] [PULL 04/11] libqos/ahci: ATAPI support, John Snow, 2016/01/08
- [Qemu-devel] [PULL 05/11] libqos/ahci: ATAPI identify, John Snow, 2016/01/08
- [Qemu-devel] [PULL 07/11] libqos: allow zero-size allocations, John Snow, 2016/01/08
- [Qemu-devel] [PULL 06/11] libqos/ahci: Switch to mutable properties, John Snow, 2016/01/08
- [Qemu-devel] [PULL 09/11] libqos/ahci: add ahci_exec, John Snow, 2016/01/08
- [Qemu-devel] [PULL 11/11] libqos/ahci: organize header, John Snow, 2016/01/08
- [Qemu-devel] [PULL 08/11] libqos/ahci: allow nondata commands for ahci_io variants, John Snow, 2016/01/08
- [Qemu-devel] [PULL 10/11] qtest/ahci: ATAPI data tests, John Snow, 2016/01/08
- Re: [Qemu-devel] [PULL 00/11] Ide patches,
Peter Maydell <=