qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 09/19] exec.c: Use cpu_get_phys_page_attrs_de


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 09/19] exec.c: Use cpu_get_phys_page_attrs_debug
Date: Mon, 11 Jan 2016 14:47:05 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0


On 16/11/2015 15:05, Peter Maydell wrote:
> -    hwaddr phys = cpu_get_phys_page_debug(cpu, pc);
> +    MemTxAttrs attrs = {};
> +    hwaddr phys = cpu_get_phys_page_attrs_debug(cpu, pc, &attrs);
> +    int asidx = cpu_asidx_from_attrs(cpu, attrs);
>      if (phys != -1) {
> -        tb_invalidate_phys_addr(cpu->as,
> +        tb_invalidate_phys_addr(cpu->cpu_ases[asidx].as,
>                                  phys | (pc & ~TARGET_PAGE_MASK));
>      }

The only question I have is whether it is right to have empty MemTxAttrs
here.  Is there any way to use the MemTxAttrs for the "current state" of
the CPU, whatever that is (on x86 I have added cpu_get_mem_attrs to
target-i386/cpu.h)?

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]