[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 14/55] ipmi: Add a local BMC simulation
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL 14/55] ipmi: Add a local BMC simulation |
Date: |
Tue, 12 Jan 2016 13:06:02 +0200 |
On Fri, Jan 08, 2016 at 10:05:44AM +0100, Paolo Bonzini wrote:
>
>
> On 22/12/2015 17:53, Michael S. Tsirkin wrote:
> > +{
> > + if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2])) {
>
> Off by one. The check should be >=, not >.
>
> Paolo
Corey, can you look into this please?
> > + return -1;
> > + }
- [Qemu-devel] [PULL 00/55] acpi, pc features, Michael S. Tsirkin, 2016/01/08
- Message not available
- Message not available
- [Qemu-devel] [PULL 01/55] mmap-alloc: tweak a comment on ppc64, Michael S. Tsirkin, 2016/01/08
- [Qemu-devel] [PULL 03/55] pc: Move legacy_acpi_table_size global to PCMachineClass, Michael S. Tsirkin, 2016/01/08
- [Qemu-devel] [PULL 02/55] pc: Move compat boolean globals to PCMachineClass, Michael S. Tsirkin, 2016/01/08
- Re: [Qemu-devel] [PULL 00/55] acpi, pc features, Peter Maydell, 2016/01/08