qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [Bug 1533141] Re: qemu/disas/libvixl/vixl/invalset.h: 2 * s


From: Peter Maydell
Subject: [Qemu-devel] [Bug 1533141] Re: qemu/disas/libvixl/vixl/invalset.h: 2 * sanity check after use ?
Date: Tue, 12 Jan 2016 11:34:35 -0000

libvixl is not part of QEMU proper, but is an upstream library which we
use (as documented in disas/libvixl/README). If you want to suggest
coding style changes to it I would recommend reporting them to the
upstream project:  https://github.com/armvixl/vixl .

QEMU just takes the most recent release of the library and includes it
in our repo without making any changes to the code if we can avoid it.


** Changed in: qemu
       Status: New => Invalid

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1533141

Title:
  qemu/disas/libvixl/vixl/invalset.h: 2 * sanity check after use ?

Status in QEMU:
  Invalid

Bug description:
  1.

  [qemu/disas/libvixl/vixl/invalset.h:442]: (style) Array index 'low' is
  used before limits check.

   while (!IsValid(elements[low]) && (low < high)) ++low;

  2.

  [qemu/disas/libvixl/vixl/invalset.h:450]: (style) Array index 'middle'
  is used before limits check.

    while (!IsValid(elements[middle]) && (middle < high - 1)) ++middle;

  Also, binary search is a standard C library routine. Suggest use.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1533141/+subscriptions



reply via email to

[Prev in Thread] Current Thread [Next in Thread]