[Qemu-devel] [Bug 1533141] Re: qemu/disas/libvixl/vixl/invalset.h: 2 * sanity check after use ?

[dcb]

>If you want to suggest coding style changes to it I would recommend reporting 
>them to the upstream project: 

Thanks. Done here:

https://github.com/armvixl/vixl/issues

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1533141

Title:
  qemu/disas/libvixl/vixl/invalset.h: 2 * sanity check after use ?

Status in QEMU:
  Invalid

Bug description:
  1.

  [qemu/disas/libvixl/vixl/invalset.h:442]: (style) Array index 'low' is
  used before limits check.

   while (!IsValid(elements[low]) && (low < high)) ++low;

  2.

  [qemu/disas/libvixl/vixl/invalset.h:450]: (style) Array index 'middle'
  is used before limits check.

    while (!IsValid(elements[middle]) && (middle < high - 1)) ++middle;

  Also, binary search is a standard C library routine. Suggest use.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1533141/+subscriptions