Re: [Qemu-devel] [PATCH 5/7] qapi: rename input buttons

[Daniel P. Berrange]

On Tue, Jan 12, 2016 at 01:29:37PM +0100, Gerd Hoffmann wrote:
> All lowercase, use-dash instead of CamelCase.
> 
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  hw/input/hid.c              | 4 ++--
>  hw/input/ps2.c              | 4 ++--
>  hw/input/virtio-input-hid.c | 4 ++--
>  monitor.c                   | 2 +-
>  qapi-schema.json            | 5 +----
>  qmp-commands.hx             | 4 ++--
>  ui/cocoa.m                  | 4 ++--
>  ui/gtk.c                    | 4 ++--
>  ui/input-legacy.c           | 4 ++--
>  ui/sdl.c                    | 4 ++--
>  ui/sdl2.c                   | 4 ++--
>  ui/spice-input.c            | 4 ++--
>  ui/vnc.c                    | 4 ++--
>  13 files changed, 24 insertions(+), 27 deletions(-)

Reviewed-by: Daniel P. Berrange <address@hidden>


> diff --git a/qapi-schema.json b/qapi-schema.json
> index 3884479..511702f 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3662,12 +3662,9 @@
>  # Button of a pointer input device (mouse, tablet).
>  #
>  # Since: 2.0
> -#
> -# Note that the spelling of these values may change when the
> -# x-input-send-event is promoted out of experimental status.
>  ##
>  { 'enum'  : 'InputButton',
> -  'data'  : [ 'Left', 'Middle', 'Right', 'WheelUp', 'WheelDown' ] }
> +  'data'  : [ 'left', 'middle', 'right', 'wheel-up', 'wheel-down' ] }

Ok, this rename is safe todo, since this enum is only used from the
experimental x-input-send-event command

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|