Re: [Qemu-devel] [PATCH 2/6] console: block rendering until client is done

[Marc-André Lureau]

Hi

On Wed, Jan 13, 2016 at 1:02 PM, Gerd Hoffmann <address@hidden> wrote:
> Allow gl user interfaces to block display device gl rendering.
> The ui code might want to do that in case it takes a little
> longer to bring things to screen, for example because we'll
> hand over a dma-buf to another process (spice will do that).
>
> Signed-off-by: Gerd Hoffmann <address@hidden>

Reviewed-by: Marc-André Lureau <address@hidden>

> ---
>  include/ui/console.h |  2 ++
>  ui/console.c         | 10 ++++++++++
>  2 files changed, 12 insertions(+)
>
> diff --git a/include/ui/console.h b/include/ui/console.h
> index adac36d..12ad627 100644
> --- a/include/ui/console.h
> +++ b/include/ui/console.h
> @@ -362,6 +362,7 @@ typedef struct GraphicHwOps {
>      void (*text_update)(void *opaque, console_ch_t *text);
>      void (*update_interval)(void *opaque, uint64_t interval);
>      int (*ui_info)(void *opaque, uint32_t head, QemuUIInfo *info);
> +    void (*gl_block)(void *opaque, bool block);
>  } GraphicHwOps;
>
>  QemuConsole *graphic_console_init(DeviceState *dev, uint32_t head,
> @@ -374,6 +375,7 @@ void graphic_console_set_hwops(QemuConsole *con,
>  void graphic_hw_update(QemuConsole *con);
>  void graphic_hw_invalidate(QemuConsole *con);
>  void graphic_hw_text_update(QemuConsole *con, console_ch_t *chardata);
> +void graphic_hw_gl_block(QemuConsole *con, bool block);
>
>  QemuConsole *qemu_console_lookup_by_index(unsigned int index);
>  QemuConsole *qemu_console_lookup_by_device(DeviceState *dev, uint32_t head);
> diff --git a/ui/console.c b/ui/console.c
> index 4b65c34..f0a4bd8 100644
> --- a/ui/console.c
> +++ b/ui/console.c
> @@ -261,6 +261,16 @@ void graphic_hw_update(QemuConsole *con)
>      }
>  }
>
> +void graphic_hw_gl_block(QemuConsole *con, bool block)
> +{
> +    if (!con) {
> +        con = active_console;
> +    }
> +    if (con && con->hw_ops->gl_block) {
> +        con->hw_ops->gl_block(con->hw, block);
> +    }
> +}
> +
>  void graphic_hw_invalidate(QemuConsole *con)
>  {
>      if (!con) {
> --
> 1.8.3.1
>



-- 
Marc-André Lureau